Conversation
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
force-pushed
the
ji/compat-testing
branch
from
702084f to
390cd49
Compare
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
|
|
||
| ### Fixture Suite | ||
|
|
||
| **Synthetic fixtures** (deterministic, hardcoded values): |
There was a problem hiding this comment.
I assume this is just a sample and we would have many more?
| ### API Adapter Layer | ||
|
|
||
| The only part that changes per version. When cherry-picking onto an old branch, you adapt this module (~20 lines). |
There was a problem hiding this comment.
In theory this makes sense, but in practice how would this work? Do we have to copy and paste this code 30 times in different files for every version? Also, where does this code actually live?
There was a problem hiding this comment.
We have to hot-fix all release (branch or new release) with code that will write all vx files that version could. It is a medium amount of work
robert3005
left a comment
robert3005
left a comment
There was a problem hiding this comment.
I think this proposal makes sense. The one thing we have to figure out is what consitutes a reasonable fixture? Likely there should be coverage for every expression and layout, i.e. you could contrive this file that has full coverage as a first level sanity check of every version.
3 participants
No description provided.